Handle valid_from=None in configuration version selection #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovv
force-pushed
the
ovv/lookup-quix-config-service-valid-from
branch
from
7179514 to
5cc2844
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ovv
force-pushed
the
ovv/lookup-quix-config-service-valid-from
branch
from
c7129e5 to
fff3b4f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ive tests - Refactor Configuration.find_valid_version and _find_versions to handle edge cases - Add tests the quix configuration service lookup
ovv
force-pushed
the
ovv/lookup-quix-config-service-valid-from
branch
from
fff3b4f to
24bedb6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the handling of valid_from=None by treating configurations without a timestamp as always valid, and updates the version selection logic and tests accordingly.
- Event metadata now allows
valid_fromto beNoneand maps it to0ms inConfigurationVersion.from_event. find_valid_versionand_find_versionshave been refined to correctly cache and select versions, including those withvalid_from=0.- A comprehensive test suite was added to cover
Nonetimestamps and edge cases in version lookup and join operations.
Comments suppressed due to low confidence (2)
quixstreams/dataframe/joins/lookups/quix_configuration_service/models.py:157
- [nitpick] Consider updating the docstring for
ConfigurationVersion.from_eventto clarify that aNonevalid_fromis treated as always valid (initialized to0milliseconds).
raw_valid_from = event["metadata"]["valid_from"]
quixstreams/dataframe/joins/lookups/quix_configuration_service/models.py:241
- [nitpick] The docstring for
find_valid_versioncould be extended to mention that versions withvalid_fromequal to0(i.e., no timestamp) are considered valid from the very beginning.
def find_valid_version(self, timestamp: int) -> Optional[ConfigurationVersion]:
gwaramadze
previously approved these changes
Jul 15, 2025
quixstreams/dataframe/joins/lookups/quix_configuration_service/models.py
Outdated
Show resolved
Hide resolved
quixstreams/dataframe/joins/lookups/quix_configuration_service/models.py
Outdated
Show resolved
Hide resolved
tests/test_quixstreams/test_dataframe/test_joins/test_lookup_quix_config.py
Outdated
Show resolved
Hide resolved
tests/test_quixstreams/test_dataframe/test_joins/test_lookup_quix_config.py
Show resolved
Hide resolved
tests/test_quixstreams/test_dataframe/test_joins/test_lookup_quix_config.py
Show resolved
Hide resolved
…/models.py Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
…/models.py Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
…uix_config.py Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
gwaramadze
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A configuration with
valid_from=Noneis always valid