-
Notifications
You must be signed in to change notification settings - Fork 4k
Upgrade RabbitMQ Prometheus sample docker images #14953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade RabbitMQ Prometheus sample docker images #14953
Conversation
michaelklishin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have one nitpick.
This is a non-functional change so I don't think you need to sign our CLA but if you could do that, our team would appreciate it.
| rmq0: &rabbitmq | ||
| # https://hub.docker.com/r/pivotalrabbitmq/rabbitmq/tags | ||
| image: pivotalrabbitmq/rabbitmq:master-otp-max | ||
| image: rabbitmq:4.0-management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 4-management instead of 4.0 specifically.
|
Hey @michaelklishin thanks for the review. I am from AWS, I think I am already covered for the CLA. |
|
@kenliao94 ah, OK. Then you are :) |
Upgrade RabbitMQ Prometheus sample docker images (backport #14953)
Proposed Changes
The RabbitMQ Prometheus demo is outdated with Dockers images that are unable to start. It also references deprecated
docker-composeCLI command.I upgraded the Docker images to use RabbitMQ 4 and a new version of
cadvisorand changed the Makefile to usedocker composeinstead ofdocker-composeI also updated the doc at rabbitmq/rabbitmq-website#2393
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.