Skip to content

Conversation

@kenliao94
Copy link
Contributor

Proposed Changes

The RabbitMQ Prometheus demo is outdated with Dockers images that are unable to start. It also references deprecated docker-compose CLI command.

I upgraded the Docker images to use RabbitMQ 4 and a new version of cadvisor and changed the Makefile to use docker compose instead of docker-compose

I also updated the doc at rabbitmq/rabbitmq-website#2393

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@mergify mergify bot added the make label Nov 14, 2025
@kenliao94 kenliao94 changed the title Upgrade prometheus docker images Upgrade RabbitMQ Prometheus sample docker images Nov 14, 2025
Copy link
Collaborator

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have one nitpick.

This is a non-functional change so I don't think you need to sign our CLA but if you could do that, our team would appreciate it.

rmq0: &rabbitmq
# https://hub.docker.com/r/pivotalrabbitmq/rabbitmq/tags
image: pivotalrabbitmq/rabbitmq:master-otp-max
image: rabbitmq:4.0-management
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4-management instead of 4.0 specifically.

@kenliao94
Copy link
Contributor Author

Hey @michaelklishin thanks for the review. I am from AWS, I think I am already covered for the CLA.

@michaelklishin
Copy link
Collaborator

@kenliao94 ah, OK. Then you are :)

@michaelklishin michaelklishin modified the milestones: 4.2.1, 4.3.0 Nov 14, 2025
@michaelklishin michaelklishin merged commit 3751301 into rabbitmq:main Nov 14, 2025
289 checks passed
michaelklishin added a commit that referenced this pull request Nov 14, 2025
Upgrade RabbitMQ Prometheus sample docker images  (backport #14953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants