Remove old disk base policies #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rs-danielg
suggested changes
May 30, 2021
Contributor
rs-danielg
left a comment
rs-danielg
left a comment
There was a problem hiding this comment.
If the old policies are removed, any deployments using it will lack variables. This will throw terraform errors and require manual remediation.
$ terraform plan
Error: Unsupported argument
on new-disk.tf line 27, in module "rs_sd_policy":
27: rhel_disk_usage = {
An argument named "rhel_disk_usage" is not expected here.
How is that being addressed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing OS specific disk policies in favour of the new OS agnostic policy that's based solely on percentage used
OS/filesystem specific instructions added to https://one.rackspace.com/display/MGCP/MGCP+-+Base+Policy+-+Disk+Usage+-+OS+resize which is included in the new disk alert's instructions.