Move SparseArrays to a package extension #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes SparseArrays an optional dependency by moving all SparseArrays-specific functionality to a package extension. This reduces the default dependency footprint while maintaining full compatibility when SparseArrays is loaded. Changes: - Move all SparseArrays-specific methods to ext/DimensionalDataSparseArraysExt/ - Remove SparseArrays from regular dependencies in Project.toml - Add SparseArrays as a weak dependency with extension mapping - Remove SparseArrays import from src/DimensionalData.jl The extension provides: - copyto\! methods for CHOLMOD.Dense types - copyto\! methods between AbstractDimArray and sparse matrix types - copy\! methods for sparse vectors All functionality remains unchanged when SparseArrays is loaded. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Claude doesn't know test extras apparently, so I added SparseArrays |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
+ Coverage 84.82% 86.27% +1.44%
==========================================
Files 53 54 +1
Lines 5273 5282 +9
==========================================
+ Hits 4473 4557 +84
+ Misses 800 725 -75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! But not sure why codecov is lower. I guess sparsearrays doesn't actually get tested somehow? |
|
No much it seems. Maybe Claude can write a few more tests! Not sure it understands codecov reports yet... |
|
I'll tell it to do that tonight |
|
@codecov-ai-reviewer test |
1 similar comment
|
@codecov-ai-reviewer test |
|
On it! Codecov is generating unit tests for this PR. |
|
uuh 👀 is this free? Seems quite good all told |
|
Seems to be! |
* test: add unit tests for PR#1048 * cholmod copyto! is broken * Fix CHOLMOD.Dense 1D comparison in SparseArrays tests (#1067) CHOLMOD.Dense always creates 2D arrays (nx1 matrices) even for 1D input. The test was incorrectly comparing a 1D DimArray with a 2D CHOLMOD.Dense. Fixed by using vec() to flatten the CHOLMOD.Dense array for comparison. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com> --------- Co-authored-by: codecov-ai[bot] <156709835+codecov-ai[bot]@users.noreply.github.com> Co-authored-by: Rafael Schouten <rafaelschouten@gmail.com> Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
rafaqz
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ext/DimensionalDataSparseArraysExt/with all SparseArrays-specific methodsTest plan
Tested locally by:
copyto\!between DimArrays and sparse matricescopyto\!with CHOLMOD.Dense typescopy\!with sparse vectorsAll existing tests should continue to pass.
🤖 Generated with Claude Code