Skip to content

Change default exit code behavior to match norm #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change default exit code behavior to match norm #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6af1164
Change default exit code behavior to match norm
dkniffin Aug 15, 2016
0bb59b1
Disable exit_on_failure? for tests
dkniffin Aug 15, 2016
57821ba
Merge branch 'master' into bug/default-failure-exit-code
dkniffin Jan 26, 2018
6fd3c1d
Update spec stub
dkniffin Jan 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/thor/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ def from_superclass(method, default = nil)

# A flag that makes the process exit with status 1 if any error happens.
def exit_on_failure?
false
true
end

#
Expand Down
4 changes: 4 additions & 0 deletions spec/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@
ARGV.replace []
end

config.before(:each) do
allow_any_instance_of(Thor::Base::ClassMethods).to receive(:exit_on_failure?).and_return(false)
end

config.expect_with :rspec do |c|
c.syntax = :expect
end
Expand Down