feat: Add Ionos Cloud node driver support #1633
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ionos Cloud is yet another cloud provider, it is lucrative performance and price-wise, therefore deploying RKE2 clusters with their written node driver would be really great.
Solution
ionoscloud_configinrancher2_machine_config_v2ionoscloud_credential_configinrancher2_cloud_credentialadd_cluster_credentialinrancher2_node_driver(Ionoscloud's driver is adding its credential support upon installation)Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
N/A
Regressions Considerations
N/A
Notes
username + passwordortokenfields, so technically one is optional if another is present (thus required). I am not sure how to correctly label what isoptionaland what isrequiredin such case. Please advisekubectl apply, which forces requiredidand then it correctly matches the definedconst ionoscloudConfigDriverfor all required credential/cluster operations. Would be nice to be able to set theidfrom terraform, but i do get why its not settable, as same nodedriver can be installed multiple times (for whatever reason). However it would still be nice to force theidfrom terraform when required. Any thoughts on this?Kind regards