Skip to content

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Oct 6, 2025

Currently going through older issues and trying to fix the Docker issues in #652. This basically uses the linux built-in curl for downloading the uv installation instead of ADD.

CCing @d-kleine as the Docker expert :)

Fixes #652

@rasbt rasbt mentioned this pull request Oct 6, 2025
@d-kleine
Copy link
Contributor

d-kleine commented Oct 7, 2025

I took the code for the Dockerfile from the official uv instructions that uses ADD: https://docs.astral.sh/uv/guides/integration/docker/#installing-uv

@rasbt
Copy link
Owner Author

rasbt commented Oct 7, 2025

Oh I see, not sure why this was causing problems for some.

@d-kleine
Copy link
Contributor

d-kleine commented Oct 7, 2025

This would be the correct curl command: https://docs.astral.sh/uv/getting-started/installation/

To be honest, I think it would be better to keep the Dockerfile as it is. For me, this looks like a singular issue reported without any error details, reproduction steps or valid evidence. I double-checked the report back in the day, and there were no issues after all. Furthermore, changing the code might break the config, or require extra steps, e.g. for permissions.

As long as users stick to the Docker Environment Setup Guide, everything should be fine.

@rasbt
Copy link
Owner Author

rasbt commented Oct 7, 2025

Thanks, and noted. Let's leave it as is for now as it is the officially recommended way. Thanks for looking into it!

@rasbt rasbt closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker file issue
2 participants