Camera tuning improvements #297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CDN (colour denoise) deviation gets gradually reduced frame by frame as TDN (temporal denoise) comes in and has more effect. The tuning file parameters are chosen so that existing tuning files don't have to be updated and will carry on working "mostly like they did" (apart from the new back-off). Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
The default noise/sharpness/gamma values are updated to reflect the latest camera tuning work. - Denoise is inceased when not using temporal denoise. - Denoise is reduced when benefitting from temporal denoise. - Over-sharpening is reduced. - High contrast gamma is slightly reduced. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Noise and detail tuning is improved for all official Raspberry Pi cameras. The old tunings left too much noise in and even sharpened some of it. The new tunings remove more noise, and no longer sharpen it. Some of the more general over-sharpening is also removed. Note that lost detail can be recovered well using TDN (temporal denoise), which is the recommended method to get the best results. There are some minor adjustments to the CDN deviation, now that this gets backed-off as TDN ramps up. The contrast in the gamma in the bright areas is also toned down just a little. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Same updates as to the official cameras. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Sharpening is reduced slightly for official Raspberry Pi cameras, and exposure profiles made a bit more consistent. Denoise is reduced for the imx708 where it appears too strong. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
The sharpening default values are updated to be slightly less aggressive, and exposure profiles are made slightly more consistent. This now matches the latest tuning changes. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
We use the legacy format for the VC4 platform, and are not planning to change this. So remove the warning. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of tuning improvements (esp. for PiSP), matching updates to default values in the tuning tool etc.