media: ov9282: Add external trigger mode support #6954
+91
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds DT property `trigger-mode` to enable FSIN-triggered frame capture. Includes overlay and README update for ov9281_trig. Signed-off-by: Your Name <ofedemen@lectrontech.com>
Signed-off-by: omer <ofedemen@lectrontech.com>
Adds DT property `trigger-mode` to enable FSIN-triggered frame capture. Includes overlay and README update for ov9281_trig. Signed-off-by: Your Name <ofedemen@lectrontech.com>
|
Please squash your ov9282 commits into one, then split that in two - one for the driver changes and one for the overlay changes. You can then run With those changes, I presume you are happy with this @6by9? |
|
Any comments or progress on this? |
6by9
requested changes
Aug 12, 2025
| /* Start streaming */ | ||
| ret = ov9282_write_reg(ov9282, OV9282_REG_MODE_SELECT, | ||
| 1, OV9282_MODE_STREAMING); | ||
| 1, OV9282_MODE_STREAMING); |
There was a problem hiding this comment.
Odd whitespace change for no reason
| @@ -992,15 +1060,25 @@ static int ov9282_start_streaming(struct ov9282 *ov9282) | |||
| } | |||
|
|
|||
| /* Setup handler will write actual exposure and gain */ | |||
| ret = __v4l2_ctrl_handler_setup(ov9282->sd.ctrl_handler); | |||
| ret = __v4l2_ctrl_handler_setup(ov9282->sd.ctrl_handler); | |||
|
|
||
| /* 1 frame per trigger */ | ||
| ov9282_write_reg(ov9282, OV9282_REG_NUM_FRAME_ON_TRIG, 1, 0x01); | ||
| if (ret) { |
There was a problem hiding this comment.
You've not saved the result of ov9282_write_reg to ret, so this will never fail.
Ditto subsequent calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DT property
trigger-modeto enable FSIN-triggered frame capture. Includes overlay and README update for ov9281_trig.#5349 (comment)