BTstack prepare for packet logs #425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll switch this to develop if you don't mind. |
|
Sorry, both should have been for 'develop' |
mringwal
changed the title
|
We do some of this in the sdk https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/pico_cyw43_driver/btstack_cyw43.c#L54 where we also check ENABLE_SEGGER_RTT. Maybe we should call hci_dump_enable_packet_log in there as well? |
|
I see. In this case, we can close this PR. The point is, how would people (incl. me) find this? |
|
Maybe I should add a README for the bluetooth examples? The macro is commented out here https://github.com/raspberrypi/pico-examples/blob/master/pico_w/bt/CMakeLists.txt#L53 |
|
A README would be great! |
|
Is this any good? #427 |
przymi
suggested changes
Feb 22, 2024
mringwal
force-pushed
the
btstack-prepare-for-packet-logs
branch
from
697a29b to
27525a3
Compare
|
I think we did this? Please reopen if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users have problems, the most efficient way is to analyze the packet logs. This PR makes it easier to enable the packet logger.