Skip to content

Remove second arguments from pico_package_uf2_output functions #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

will-v-pi
Copy link
Contributor

@will-v-pi will-v-pi added this to the 2.2.0 milestone Jul 22, 2025
@will-v-pi will-v-pi requested a review from kilograham July 22, 2025 13:44
kilograham
kilograham previously approved these changes Jul 23, 2025
@@ -52,7 +52,7 @@ function(pico_add_extra_outputs TARGET)
get_target_property(BINARY_TYPE ${SOURCE_TARGET} PICO_TARGET_BINARY_TYPE)
if (${BINARY_TYPE} STREQUAL "no_flash")
message("Packaging no_flash universal binary to SRAM, so it has a load_map")
pico_package_uf2_output(${SOURCE_TARGET} 0x20000000)
pico_ensure_load_map(${SOURCE_TARGET})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we maybe clarify the message and/or add a comment ... it isn't clear what or why this is packaging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have clarified the message and added a comment explaining why

@will-v-pi
Copy link
Contributor Author

Rebased to fix CI (rom_pick_ab_update_partition -> rom_pick_ab_partition_during_update rename)

@will-v-pi will-v-pi requested a review from kilograham July 24, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants