Remove second arguments from pico_package_uf2_output functions #678
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
previously approved these changes
Jul 23, 2025
kilograham
reviewed
Jul 23, 2025
| @@ -52,7 +52,7 @@ function(pico_add_extra_outputs TARGET) | |||
| get_target_property(BINARY_TYPE ${SOURCE_TARGET} PICO_TARGET_BINARY_TYPE) | |||
| if (${BINARY_TYPE} STREQUAL "no_flash") | |||
| message("Packaging no_flash universal binary to SRAM, so it has a load_map") | |||
| pico_package_uf2_output(${SOURCE_TARGET} 0x20000000) | |||
| pico_ensure_load_map(${SOURCE_TARGET}) | |||
There was a problem hiding this comment.
can we maybe clarify the message and/or add a comment ... it isn't clear what or why this is packaging
There was a problem hiding this comment.
Have clarified the message and added a comment explaining why
will-v-pi
commented
Jul 23, 2025
|
Rebased to fix CI (rom_pick_ab_update_partition -> rom_pick_ab_partition_during_update rename) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See raspberrypi/pico-sdk#2545