Skip to content

Fixing issue with tabbing when a radio is the last element of the modal #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fixing issue with tabbing when a radio is the last element of the modal #1045

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
35f7eb0
Fixed issue where tabbing wouldn't loop correctly for radio elements …
loganscharen Mar 8, 2024
ed2b7dc
Added test for tabbing with radio as last element
loganscharen Mar 8, 2024
d11722a
Moved radios to end of form
loganscharen Mar 8, 2024
40232ee
Moved radio check to function
loganscharen Mar 8, 2024
704521f
Update src/helpers/scopeTab.js
loganscharen Mar 12, 2024
3b3fbc0
Update src/helpers/scopeTab.js
loganscharen Mar 12, 2024
e94aaa1
Reverted index.js
loganscharen Mar 12, 2024
273f71f
Fixed lint issues
loganscharen Mar 14, 2024
9609eb1
Update src/helpers/scopeTab.js
loganscharen Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/helpers/scopeTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@ function getActiveElement(el = document) {
}

function areFromSameRadioGroup(a, b) {
return (
activeElement.type === "radio" &&
tail.type === "radio" &&
tail.name === activeElement.name
);
return a.type === "radio" && b.type === "radio" && a.name === b.name;
}

export default function scopeTab(node, event) {
Expand All @@ -38,9 +34,8 @@ export default function scopeTab(node, event) {
}

if (
(tail === activeElement ||
areFromSameRadioGroup(activeElement, tail)) &&
!shiftKey
(tail === activeElement || areFromSameRadioGroup(activeElement, tail)) &&
!shiftKey
) {
target = head;
}
Expand Down