Skip to content

Conversation

ViXP
Copy link
Contributor

@ViXP ViXP commented Oct 3, 2017

Class with @ didn't work with export in footer (there is no need to set classes in global scope if they will be exported anyway, imho)

…with export in footer, there is no need to set classes in global scope if they will be exported anyway)
@BookOfGreg
Copy link
Member

BookOfGreg commented Oct 3, 2017

Agreed.
Just spun up my first webpack + Coffeescript project here so that I can actually start testing these things for you. Yep you're totally right, no @ needed.
Later on I'll write a test for this in this project but thanks.

Edit: I'll clean up the test failure in a moment.

@BookOfGreg BookOfGreg merged commit 8cf38f3 into reactjs:master Oct 3, 2017
@BookOfGreg
Copy link
Member

@rmosolgo
Copy link
Member

rmosolgo commented Oct 3, 2017

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants