Replace reading order indices with HREFs in the EPUB viewport #624
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces reading order indices with HREF values for the EPUB viewport, aligning the API with other parts of the system.
- Replaces the reading order indices and progressions dictionary keys with HREFs.
- Introduces a mapping for visible reading order resources to associate indices with their corresponding HREFs.
Comments suppressed due to low confidence (2)
Sources/Navigator/EPUB/EPUBNavigatorViewController.swift:635
- [nitpick] Consider renaming the tuple variable 'i' to a more descriptive name (e.g., 'resource') to enhance code readability.
progressions: visibleReadingOrder.reduce([:]) { progressions, i in
Sources/Navigator/EPUB/EPUBNavigatorViewController.swift:136
- Confirm that the updated comment clearly conveys that the array contains HREFs rather than indices, to maintain consistency with the API design.
/// Visible reading order resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace reading order indices with HREFs in the EPUB viewport, to stay consistent with our other APIs which use HREFs instead of an index.