Add the ability to customize audio parser specifications and ignored file extensions #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grighakobian
changed the title
grighakobian
changed the title
mickael-menu
reviewed
Jul 7, 2025
There was a problem hiding this comment.
Allowing to customize the supported audio format specifications in the audio parser makes sense to me.
However I don't think we really need the ignoredExtensions, as the reading order is built by filtering the resources to audioSpecifications. Did you try removing the ignoredExtensions altogether?
grighakobian
force-pushed
the
fix/audio-parser
branch
from
9b20751 to
85c66cf
Compare
|
@mickael-menu You're right, I don't actually need to add .pdf or .jpg as ignored extensions. So I'll go ahead and close this pull request, since I also don't really need to customize the audio specifications after all. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Opening zipped audiobooks that contain JPG and PDF files results in a
PublicationParseError.formatNotSupported.The Solution
Added support to customize audio parser specifications and ignored file extensions