Update audio publication manifest augmentor api #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
reviewed
Jul 7, 2025
grighakobian
force-pushed
the
feat/update-audio-publication-manifest-augmentor
branch
from
cedc37f to
6e1d596
Compare
Done! |
mickael-menu
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Some zipped audiobooks containing MP3 files fail to parse the duration of the audio files. Additionally, the
AudioPublicationAugmentedManifestinitializer is internal, preventing the use of a customAudioPublicationManifestAugmentor.The Solution
To parse the duration, we use the resource item to read the entry data. Since the data reader functions are asynchronous, I decided to update the
AudioPublicationManifestAugmentorAPI to support async. I also modified theAudioPublicationAugmentedManifestinitializer to allow the use of a customAudioPublicationManifestAugmentor.