-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add utility method for explicitly setting cache tags to cache tag class #12495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agjohnson
wants to merge
8
commits into
main
Choose a base branch
from
agj/add-download-cache-tag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
I think this likely also might have downstream permissions issues on .com. We should double check that these aren't being cached on .com. |
This only affects cache tagging for purging, so shouldn't have an effect on caching. |
ericholscher
reviewed
Oct 1, 2025
agjohnson
added a commit
that referenced
this pull request
Oct 1, 2025
agjohnson
added a commit
that referenced
this pull request
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the first attempt to fix #12494, then was broken up into multiple stages of work. This is a very minor method addition to the cache tag class, used when project/version are not set on the view instance at the class level. This was an issue in multiple views.