Skip to content

Add GITHUB_APP_NAME to context processor #12511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2025
Merged

Add GITHUB_APP_NAME to context processor #12511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8729759
Add GITHUB_APP_NAME to context processor
ericholscher Oct 8, 2025
ec3bf45
Remove other use of passing GITHUB_APP_NAME
ericholscher Oct 9, 2025
60d3358
Remove old logic
ericholscher Oct 12, 2025
586539d
Fix test for context processor
ericholscher Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions readthedocs/core/context_processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def readthedocs_processor(request):
"SUPPORT_EMAIL": settings.SUPPORT_EMAIL,
"PUBLIC_API_URL": settings.PUBLIC_API_URL,
"ADMIN_URL": settings.ADMIN_URL,
"GITHUB_APP_NAME": settings.GITHUB_APP_NAME,
}
return exports

Expand Down
7 changes: 0 additions & 7 deletions readthedocs/profiles/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ def test_migration_page_initial_state(self, request):

assert context["step"] == "overview"
assert context["step_connect_completed"] is False
assert context["github_app_name"] == "readthedocs"
assert list(context["migrated_projects"]) == []
assert (
context["old_application_link"]
Expand Down Expand Up @@ -344,7 +343,6 @@ def test_migration_page_step_connect_done(self, request):

assert context["step"] == "overview"
assert context["step_connect_completed"] is True
assert context["github_app_name"] == "readthedocs"
assert list(context["migrated_projects"]) == []
assert (
context["old_application_link"]
Expand Down Expand Up @@ -437,7 +435,6 @@ def test_migration_page_step_install_done(self, request):

assert context["step"] == "overview"
assert context["step_connect_completed"] is True
assert context["github_app_name"] == "readthedocs"
assert list(context["migrated_projects"]) == []
assert (
context["old_application_link"]
Expand Down Expand Up @@ -541,7 +538,6 @@ def test_migration_page_step_migrate_one_project(

assert context["step"] == "overview"
assert context["step_connect_completed"] is True
assert context["github_app_name"] == "readthedocs"
assert list(context["migrated_projects"]) == [
self.project_with_remote_repository,
]
Expand Down Expand Up @@ -638,7 +634,6 @@ def test_migration_page_step_migrate_all_projects(

assert context["step"] == "overview"
assert context["step_connect_completed"] is True
assert context["github_app_name"] == "readthedocs"
assert list(context["migrated_projects"]) == [
self.project_with_remote_repository,
self.project_with_remote_organization,
Expand Down Expand Up @@ -731,7 +726,6 @@ def test_migration_page_step_migrate_one_project_with_errors(

assert context["step"] == "overview"
assert context["step_connect_completed"] is True
assert context["github_app_name"] == "readthedocs"
assert list(context["migrated_projects"]) == [
self.project_with_remote_repository,
]
Expand Down Expand Up @@ -824,7 +818,6 @@ def test_migration_page_step_revoke_done(self, request):

assert context["step"] == "overview"
assert context["step_connect_completed"] is True
assert context["github_app_name"] == "readthedocs"
assert list(context["migrated_projects"]) == []
assert (
context["old_application_link"]
Expand Down
1 change: 0 additions & 1 deletion readthedocs/profiles/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ def get_context_data(self, **kwargs):
user = self.request.user

context["step_connect_completed"] = self._has_new_accounts_for_old_accounts()
context["github_app_name"] = settings.GITHUB_APP_NAME
context["migrated_projects"] = get_migrated_projects(user)
context["old_application_link"] = get_old_app_link()
context["step_revoke_completed"] = self._is_access_to_old_github_accounts_revoked()
Expand Down
1 change: 0 additions & 1 deletion readthedocs/projects/views/private.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ def get_context_data(self, **kwargs):
context["allow_private_repos"] = settings.ALLOW_PRIVATE_REPOS
context["form_automatic"] = ProjectAutomaticForm(user=self.request.user)
context["form_manual"] = ProjectManualForm(user=self.request.user)
context["GITHUB_APP_NAME"] = settings.GITHUB_APP_NAME

return context

Expand Down
1 change: 1 addition & 0 deletions readthedocs/rtd_tests/tests/test_notifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ class TestNotification(EmailNotification):
"TEMPLATE_ROOT": mock.ANY,
"USE_PROMOS": mock.ANY,
"USE_ORGANIZATIONS": mock.ANY,
"GITHUB_APP_NAME": mock.ANY,
},
)

Expand Down