-
-
Notifications
You must be signed in to change notification settings - Fork 411
[php 8.5] Pipe Operator #7201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[php 8.5] Pipe Operator #7201
Conversation
arshidkv12
commented
Aug 30, 2025
|
||
public function getNodeTypes(): array | ||
{ | ||
return [Assign::class, FuncCall::class]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should use StmtsAwareInterface, loop and break/skip when extra vars is used or in the middle per example at https://amitmerchant.com/everything-that-is-coming-in-php-85/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
if (! $node->expr instanceof FuncCall) { | ||
return null; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip $node->firstClassCallable()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. vendor/bin/phpstan analyse --ansi
not working.
vendor/bin/phpstan analyse --ansi
Note: Using configuration file /Users/arshid/Downloads/rector-src/phpstan.neon.
In Resolver.php line 482:
Service 'rules.0' (type of Symplify\PHPStanRules\Rules\NoDynamicNameRule): Service of type Symplify\PHPStanRules\TypeAnalyzer\CallableTypeAnalyzer
required by $callableTypeAnalyzer in NoDynamicNameRule::__construct() not found. Did you add it to configuration file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce, you may have vendor/ issue, probably remove and run composer update:
rm -rf vendor
composer update