Remove Pbench arguments from general_setup
#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all pbench arguments as it is no longer supported by Zathras. Any configuration files will need to remove the use of these arguments or at least avoid going down code paths that do use them. BREAKING CHANGE: Pbench argument removal Co-developed-by: Cursor
frival
approved these changes
Aug 26, 2025
dvalinrh
added
the
group_review_lgtm
dvalinrh
requested changes
Sep 2, 2025
|
|
||
| to_puser=`whoami` | ||
| to_run_user=`whoami` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes all pbench arguments as it is no longer supported by Zathras.
Any configuration files will need to remove the use of these arguments or at least avoid going down code paths that do use them.
Before/After Comparison
Before
--pbench*options are available but will inevitably lead to broken functionalityAfter
The options are removed to prevent problems and broken functionality.
Clerical Stuff
Issue TBD
Relates to JIRA: RPOPC-<TICKET_NUMBER>