Skip to content

Tombstone messages in kafka should trigger the conditional delete not throw an error #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tombstone messages in kafka should trigger the conditional delete not throw an error #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b288c14
Making a change to make null's call the conditional del.
andrecowie May 29, 2025
5d4a99b
Merge branch 'master' into master
andrecowie Jul 18, 2025
cdbfe55
Adding value == null return emptyMap
andrecowie Jul 18, 2025
9b3dee4
REVERT 21 TO 17
andrecowie Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,9 @@ private Map<byte[], byte[]> map(SinkRecord sinkRecord) {
}
return body;
}
if (value == null) {
return Collections.emptyMap();
}
throw new ConnectException("Unsupported source value type: " + sinkRecord.valueSchema().type().name());
}

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ org.gradle.daemon = false
org.gradle.caching = false
org.gradle.parallel = false
systemProp.file.encoding = utf-8
org.gradle.jvmargs = -Dfile.encoding=UTF-8
org.gradle.jvmargs = -Dfile.encoding=UTF-8