Skip to content

Conversation

aidandj
Copy link

@aidandj aidandj commented Sep 1, 2023

I wasn't sure the best way to handle adding this. Ideally in a breaking change, but I saw RestoreReplace existed, so this was kind of along those lines.

Happy to rename/re-arrange the interface, just wanted to get something started.

Signed-off-by: Aidan Jensen <aidan@artificial.com>
@ndyakov
Copy link
Member

ndyakov commented Jun 5, 2025

Hello @artificial-aidan and thank you for this PR. You were on the right track. Let's rename it to MigrateWithArgs (see

FTAggregateWithArgs(ctx context.Context, index string, query string, options *FTAggregateOptions) *AggregateCmd
for example) and create options struct for the additional options - similar to FTAggregateOptions

And please resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants