Skip to content

Handle the invalidate OOB push message. #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v5
Choose a base branch
from
Open

Handle the invalidate OOB push message. #2717

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
319ab87
support handling invalidation push messages
sjpotter Mar 14, 2024
8d827d7
update to be more generic
sjpotter Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/client/lib/client/commands-queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ export default class RedisCommandsQueue {
return this.#pubSub.isActive;
}

#pushHandlers: Map<string, (push: any[]) => unknown>;

constructor(
respVersion: RespVersions,
maxLength: number | null | undefined,
Expand All @@ -65,6 +67,7 @@ export default class RedisCommandsQueue {
this.#maxLength = maxLength;
this.#onShardedChannelMoved = onShardedChannelMoved;
this.decoder = this.#initiateDecoder();
this.#pushHandlers = new Map<string, () => unknown>();
}

#onReply(reply: ReplyUnion) {
Expand Down Expand Up @@ -109,13 +112,26 @@ export default class RedisCommandsQueue {
onErrorReply: err => this.#onErrorReply(err),
onPush: push => {
if (!this.#onPush(push)) {

const handler = this.#pushHandlers.get(push[0].toString());
if (handler === undefined) {
return;
}
handler(push)
}
},
getTypeMapping: () => this.#getTypeMapping()
});
}

setPushCallback(type: string, callback?: (push: any[]) => unknown) {
if (callback === undefined) {
this.#pushHandlers.delete(type);
return;
}

this.#pushHandlers.set(type, callback);
}

addCommand<T>(
args: CommandArguments,
options?: CommandOptions
Expand Down