Update the Session on Reads #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhodapp
requested changes
Aug 15, 2025
web/src/lib.rs
Outdated
| .with_secure(app_state.config.is_production()) | ||
| .with_same_site(tower_sessions::cookie::SameSite::Lax) // Assists in CSRF protection | ||
| .with_expiry(Expiry::OnInactivity(Duration::days(1))); | ||
| .with_expiry(Expiry::OnInactivity(Duration::days(1))) |
There was a problem hiding this comment.
Can you also add this as a new AppState Config variable that we could set on the command line or env var? The default should still be 1 day which means we won't need to change our entrypoint.sh flags when it starts up refactor_platform_rs, nor set an env var in GitHub.
jhodapp
approved these changes
Aug 15, 2025
| # API version to use between frontend and backend | ||
| BACKEND_API_VERSION=${{ vars.BACKEND_API_VERSION }} | ||
| # Session expiry duration in seconds (default: 24 hours = 86400 seconds) | ||
| BACKEND_SESSION_EXPIRY_SECONDS=${{ vars.BACKEND_SESSION_EXPIRY_SECONDS }} |
There was a problem hiding this comment.
Thanks for adding this, going above and beyond!
- Add backend_session_expiry_seconds field to Config with default 86400 seconds (24 hours) - Update session layer to use config value instead of hardcoded Duration::days(1) - Add BACKEND_SESSION_EXPIRY_SECONDS environment variable to deployment pipeline - Update docker-compose.yaml and entrypoint.sh to pass session expiry parameter - Update .env.local with default session expiry configuration This allows flexible session timeout configuration for different environments while maintaining backward compatibility with 24-hour default. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
calebbourg
force-pushed
the
179-renew-sessions-for-active-users
branch
from
7a8bb3e to
a9e91ac
Compare
github-project-automation
bot
moved this from Review
to ✅ Done
in Refactor Coaching Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our Session configuration to use
with_always_save(true)From the docs
GitHub Issue: [Fixes] #179
Changes
with_always_save(true)Testing Strategy
I tested this locally by changing the expiry to 1 minute and:
Concerns
It's not clear why
with_always_save(true)works andsave()didn't. I didn't look too deeply. My guess issave()bypasses updating the relevant internals of the session data structure.