[bugfix] Introduce optional file locking for appending to perflogs #3523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
changed the title
vkarak
force-pushed
the
bugfix/lock-filelog-append
branch
2 times, most recently
from
a10625f to
353c6d8
Compare
Also: - Introduce an `osext.flock()` utility function to handle the underlying locking for the different Python versions. - Use Python syntax for ``true`` and ``false`` in the configuration reference to be consistent with the use of ``None`` instead of the JSON's ``null``.
vkarak
force-pushed
the
bugfix/lock-filelog-append
branch
from
353c6d8 to
fac5691
Compare
|
I'm converting this to draft since the fix has to be designed in accordance with #3532. |
vkarak
force-pushed
the
bugfix/lock-filelog-append
branch
from
b6c429c to
d5b029c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new configuration variables (
locking_enableandlocking_file_mode) for thefileloghandler. Setting this will cause thefileloghandler to use file locking when appending to the perflog files.This PR also introduces the following improvements:
osext.flock()to handle the creation of the lock file for the different Python versions; this function is now used also for the DB.trueandfalsein the configuration reference to be consistent with the use ofNoneinstead of the JSON'snull.Closes #3521.