feat: graphql-codegen plugin #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
darshkpatel
force-pushed
the
03-17-feat_implement_plugin
branch
from
7657d57 to
e382df3
Compare
darshkpatel
force-pushed
the
03-17-feat_implement_plugin
branch
from
e382df3 to
e88bf85
Compare
This was referenced Mar 18, 2025
Merged
Merged
darshkpatel
commented
Mar 18, 2025
Comment on lines
+38
to
+41
| "peerDependencies": { | ||
| "@graphql-codegen/plugin-helpers": "^5.0.0", | ||
| "graphql": "^16.0.0" | ||
| }, |
There was a problem hiding this comment.
Peer deps because it's a graphql-codegen plugin, expectation is that these packages are already installed
|
Claude did a very good job adding docstrings 💅🏻 |
masad-frost
reviewed
Mar 18, 2025
masad-frost
reviewed
Mar 18, 2025
masad-frost
reviewed
Mar 18, 2025
masad-frost
reviewed
Mar 18, 2025
masad-frost
reviewed
Mar 18, 2025
masad-frost
reviewed
Mar 18, 2025
masad-frost
reviewed
Mar 18, 2025
Comment on lines
+8
to
+12
| /** | ||
| * Output format - 'server' generates hash->operation mapping, | ||
| * 'client' generates operation->hash mapping | ||
| */ | ||
| output: 'server' | 'client'; |
There was a problem hiding this comment.
I hate that we have to run the plugin twice because of how codegen works lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a stack of PRs
Allows us to do this now:
Main Changes in this PR:
Ports our existing plugin while cleaning it up and making it more structured
also adding support for
includeAlgorithmPrefixto help match the graphql-over-http spec this is still not implemented completely in the apollo graphql client so keeping it defaulted to false for now - eg. relay decided to use md5 hashescore logic remains the same, doing cosmetic changes to make the package more maintainable
Test coverage in stacked PR: feat: tests #3
Did a quick sanity check by enabling the
includeAlgorithmPrefixoption and then turning it off, matches the existing generated manifest ( Note: I plan to use it without the algorithm prefix. )