Skip to content

css optimisation : stop trying to inline css imports like //fonts.goo… #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

css optimisation : stop trying to inline css imports like //fonts.goo… #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dist/r.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27066,6 +27066,12 @@ function (lang, logger, envOptimize, file, parse,
importFileName = importFileName.replace(lang.backSlashRegExp, "/");

try {
//if an absolute path without scheme ex: //fonts.googleapis.com/icon?family=Material+Icons
//skip inlining, if not it will skip after 15seconds trying to readFile
if(importFileName.indexOf('//') === 0 ){
logger.warn(fileName + "\n Full path without scheme, Cannot inline css import, skipping: " + importFileName);
return fullMatch;
}
//if a relative path, then tack on the filePath.
//If it is not a relative path, then the readFile below will fail,
//and we will just skip that import.
Expand Down