time panel context menu sharing

Author: IsseW

crates/viewer/re_time_panel/src/time_control_ui.rs

@@ -25,7 +25,7 @@ impl TimeControlUi {
             ui.visuals_mut().widgets.hovered.expansion = 0.0;
             ui.visuals_mut().widgets.open.expansion = 0.0;
 
-            egui::ComboBox::from_id_salt("timeline")
+            let response = egui::ComboBox::from_id_salt("timeline")
                 .selected_text(time_control.timeline().name().as_str())
                 .show_ui(ui, |ui| {
                     for timeline in times_per_timeline.timelines() {
@@ -65,6 +65,25 @@ You can also define your own timelines, e.g. for sensor time or camera frame num
                             true,
                         );
                     });
+                });
+            egui::Popup::menu(&response)
+                .id(egui::Id::new("timeline select context menu"))
+                .open_memory(if response.secondary_clicked() {
+                    Some(egui::SetOpenCommand::Bool(true))
+                } else if response.clicked() {
+                    // Explicitly close the menu if the widget was clicked
+                    // Without this, the context menu would stay open if the user clicks the widget
+                    Some(egui::SetOpenCommand::Bool(false))
+                } else {
+                    None
+                })
+                .at_pointer_fixed()
+                .show(|ui| {
+                    if ui.button("Copy timeline name").clicked() {
+                        let timeline = format!("{}", time_control.timeline().name());
+                        re_log::info!("Copied timeline: {}", timeline);
+                        ui.ctx().copy_text(timeline);
+                    }
                 })
         });
     }

crates/viewer/re_time_panel/src/time_panel.rs

@@ -20,8 +20,8 @@ use re_ui::{ContextExt as _, DesignTokens, Help, UiExt as _, filter_widget, icon
 use re_ui::{IconText, filter_widget::format_matching_text};
 use re_viewer_context::{
     CollapseScope, HoverHighlight, Item, ItemCollection, ItemContext, RecordingConfig,
-    SystemCommand, SystemCommandSender as _, TimeControl, TimeView, UiLayout, ViewerContext,
-    VisitorControlFlow,
+    SystemCommand, SystemCommandSender as _, TimeControl, TimeView, UiLayout, UrlContext,
+    ViewerContext, VisitorControlFlow,
 };
 use re_viewport_blueprint::ViewportBlueprint;
 
@@ -567,6 +567,7 @@ impl TimePanel {
             &self.time_ranges_ui,
             time_ctrl,
             ui,
+            ctx,
             Some(&time_area_response),
             &time_area_painter,
             &timeline_rect,
@@ -1380,6 +1381,7 @@ impl TimePanel {
                     &time_ranges_ui,
                     time_ctrl,
                     ui,
+                    ctx,
                     None,
                     &painter,
                     &time_range_rect,
@@ -1396,7 +1398,9 @@ impl TimePanel {
         ui: &mut egui::Ui,
         time_ctrl: &mut TimeControl,
     ) {
-        if let Some(time_int) = time_ctrl.time_int() {
+        if let Some(time_int) = time_ctrl.time_int()
+            && let Some(time) = time_ctrl.time()
+        {
             let time_type = time_ctrl.time_type();
 
             let mut time_str = self
@@ -1418,11 +1422,11 @@ impl TimePanel {
                 }
                 self.time_edit_string = None;
             }
-            response
-                .on_hover_text(format!("Timestamp: {}", time_int.as_i64()))
-                .context_menu(|ui| {
-                    copy_time_properties_context_menu(ui, time_ctrl, None);
-                });
+            let response = response.on_hover_text(format!("Timestamp: {}", time_int.as_i64()));
+
+            response.context_menu(|ui| {
+                copy_time_properties_context_menu(ui, time);
+            });
         }
     }
 }
@@ -1774,29 +1778,41 @@ fn interact_with_streams_rect(
 }
 
 /// Context menu that shows up when interacting with the streams rect.
-fn copy_time_properties_context_menu(
+fn copy_timeline_properties_context_menu(
     ui: &mut egui::Ui,
+    ctx: &ViewerContext<'_>,
     time_ctrl: &TimeControl,
-    hovered_time: Option<TimeReal>,
+    hovered_time: TimeReal,
 ) {
-    if let Some(time) = hovered_time {
-        if ui.button("Copy hovered timestamp").clicked() {
-            let time = format!("{}", time.floor().as_i64());
-            re_log::info!("Copied hovered timestamp: {}", time);
-            ui.ctx().copy_text(time);
-        }
-    } else if let Some(time) = time_ctrl.time_int()
-        && ui.button("Copy current timestamp").clicked()
+    // TODO: Add shortcuts for these
+    if let Some(selected_time_range) = time_ctrl.active_loop_selection()
+        && selected_time_range.contains(hovered_time)
     {
-        let time = format!("{}", time.as_i64());
-        re_log::info!("Copied current timestamp: {}", time);
+        if ui.button("Copy link to trimmed range").clicked() {
+            ctx.command_sender()
+                .send_system(UrlContext::from_context(ctx).into_copy_cmd());
+        }
+    } else if ui.button("Copy link to timestamp").clicked() {
+        ctx.command_sender().send_system(
+            UrlContext::from_context(ctx)
+                .without_time_range()
+                .with_timestamp(time_ctrl.timeline(), hovered_time.into())
+                .into_copy_cmd(),
+        );
+    }
+
+    if ui.button("Copy timestamp").clicked() {
+        let time = format!("{}", hovered_time.floor().as_i64());
+        re_log::info!("Copied hovered timestamp: {}", time);
         ui.ctx().copy_text(time);
     }
+}
 
-    if ui.button("Copy current timeline name").clicked() {
-        let timeline = format!("{}", time_ctrl.timeline().name());
-        re_log::info!("Copied current timeline: {}", timeline);
-        ui.ctx().copy_text(timeline);
+fn copy_time_properties_context_menu(ui: &mut egui::Ui, time: TimeReal) {
+    if ui.button("Copy timestamp").clicked() {
+        let time = format!("{}", time.floor().as_i64());
+        re_log::info!("Copied hovered timestamp: {}", time);
+        ui.ctx().copy_text(time);
     }
 }
 
@@ -1805,6 +1821,7 @@ fn time_marker_ui(
     time_ranges_ui: &TimeRangesUi,
     time_ctrl: &mut TimeControl,
     ui: &egui::Ui,
+    ctx: &ViewerContext<'_>,
     time_area_response: Option<&egui::Response>,
     time_area_painter: &egui::Painter,
     timeline_rect: &Rect,
@@ -1918,8 +1935,26 @@ fn time_marker_ui(
             }
         }
 
-        time_area_response
-            .context_menu(|ui| copy_time_properties_context_menu(ui, time_ctrl, hovered_time));
+        let hovered_ctx_id = egui::Id::new("hovered timestamp context");
+        if let Some(hovered_time) = ui
+            .ctx()
+            .memory(|mem| mem.data.get_temp(hovered_ctx_id))
+            .or(hovered_time)
+        {
+            if egui::Popup::context_menu(&time_area_response)
+                .width(300.0)
+                .show(|ui| {
+                    copy_timeline_properties_context_menu(ui, ctx, time_ctrl, hovered_time);
+                })
+                .is_some()
+            {
+                ui.ctx()
+                    .memory_mut(|mem| mem.data.insert_temp(hovered_ctx_id, hovered_time));
+            } else {
+                ui.ctx()
+                    .memory_mut(|mem| mem.data.remove::<TimeReal>(hovered_ctx_id));
+            }
+        }
     }
 }