-
Notifications
You must be signed in to change notification settings - Fork 534
Add re_workspace_hack
to avoid rebuilding dependencies
#10933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emilk
wants to merge
15
commits into
main
Choose a base branch
from
emilk/cargo-workspace-hack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+775
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
ab7663a
to
3bb8d7d
Compare
3bb8d7d
to
5053b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have many crates.
They depend on 3rd party crates, with different combination of feature flags.
Depending on what target we build for (which binary, or test, etc) different feature flags gets enabled for those 3rd party crates. If they are not EXACTLY THE SAME as THE LAST TIME you compiled, they will be recompiled from scratch (I'm looking at you,
datafusion
).The solution
Enter
re_workspace_hack
:re_workspace_hack
re_workspace_hack
just beforecargo publish
Maintaining this would be hell… except we have https://crates.io/crates/cargo-hakari
TODO
re_workspace_hack
inrust_checks.py
@rerun-bot full-check