Skip to content

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 27, 2025

Related

What

TBD.

Look for the Convert to recording button in the table footer

TODO

  •  write tests for the conversion code
  • move conversion code elsewhere?
  • UI of converted recording: app id? etc.?
  • address /__properties/ clash when converting a partition table to a recording

@abey79 abey79 marked this pull request as draft August 27, 2025 15:01
Copy link

github-actions bot commented Aug 27, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
241df80 https://rerun.io/viewer/pr/11021 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 added 📺 re_viewer affects re_viewer itself include in changelog labels Aug 27, 2025
@ntjohnson1
Copy link
Member

Using this draft for discussion. This probably needs to be rebased for things to work. I had a question about how we support static data/AssertVideos more generally.

Here is an RRD that has asset videos: https://drive.google.com/file/d/1bib3X-5XZ4WbN9qVgPgpllZ4A1pqzpsA/view?usp=drive_link

If you load it in the OSS server then

from __future__ import annotations

import os

CATALOG_URL = "rerun+http://localhost:51234"
os.environ["RERUN_NOTEBOOK_ASSET"] = "serve-local"
import rerun as rr
client = rr.catalog.CatalogClient(CATALOG_URL)
all_entries = client.all_entries()
first_entry = all_entries[0]
dataset: rr.catalog.DatasetEntry = client.get_dataset_entry(name=first_entry.name)
top_view_video = dataset.dataframe_query_view(index=None, contents={"/observation.images.Lwebcam": ["AssetVideo:blob", "VideoFrameReference:timestamp"]}).df()

viewer = Viewer(width=WIDTH, height=HEIGHT, url=CATALOG_URL)
viewer.send_table("video", pa.concat_batches(top_view_video.limit(1).drop("frame_index").collect()))
viewer.send_table("video_index", pa.concat_batches(top_view_video.limit(1).collect()))
viewer

If I drop the frame_index (which is none since static) then nothing shows up under streams.
If I don't drop the frame_index an index is added (which is wrong since static).

The other confounding factor is that I probably want to include our VideoFrameReference with this but that's not static so I'm not sure how to join our static and non-static columns into a table (maybe a hyper-table question).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants