improve error message for trying to do dot access on option/array #7732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on something that is an option/array
zth
force-pushed
the
record-access-on-option-error-message
branch
from
dc7a7f6 to
57c0289
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
compiler/ml/typetexp.ml
Outdated
| (* TODO: Extend for nullable/null? *) | ||
| Format.fprintf ppf | ||
| "@[<v>You're trying to access the record field @{<info>%a@}, but the \ | ||
| thing you're trying to access it on is an @{<info>option@}.@ You need \ |
There was a problem hiding this comment.
Maybe 'value' instead of 'thing'?
There was a problem hiding this comment.
Done in ed7c2fb. Any other feedback?
cristianoc
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error message for trying to do dot access for a record field, but on something that's an option/array.
This error has been bugging me and others for a long time, because it's so non-obvious that you encountered an option (the old message didn't say) and need to unwrap.
Perfect for an action later on if we ever add optional chaining or similar.