Skip to content

Add auth_patterns support to RPM rule #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Add auth_patterns support to RPM rule #128

merged 1 commit into from
May 30, 2025

Conversation

rmohr
Copy link
Owner

@rmohr rmohr commented Mar 30, 2025

Sometimes RPM rules are on non-public locations. Add .netrc support to RPM rules.

RPM rules now supports the usual pattern:

rpm(
    ...,
    auth_patterns = {
        "storage.cloudprovider.com": "Bearer <password>"
    }
)

Copy link

github-actions bot commented Mar 30, 2025

⚠️ Optional job e2e-bzlmod-toolchain-circular-dependencies failed ⚠️

  • exit status: 1

@rmohr rmohr changed the title Add auth_patterns support rot RPM rule Add auth_patterns support to RPM rule Mar 30, 2025
@rmohr rmohr force-pushed the auth branch 2 times, most recently from 5dbdb38 to 42855a2 Compare March 30, 2025 16:26
@rmohr
Copy link
Owner Author

rmohr commented May 29, 2025

Rebased and verified on a kubevirt codebase. PTAL.

@rmohr
Copy link
Owner Author

rmohr commented May 30, 2025

Created #135 for the two unrelated fixes which I needed to verify it.

Sometimes RPM rules are on non-private locations. Add .netrc support to
RPM rules.

Signed-off-by: Roman Mohr <rmohr@google.com>
@rmohr
Copy link
Owner Author

rmohr commented May 30, 2025

Created #135 for the two unrelated fixes which I needed to verify it.

Done

Copy link
Collaborator

@manuelnaranjo manuelnaranjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmohr rmohr merged commit e72ea52 into main May 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants