Allow cbor2 versions above 5.0 #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise cbor2 limit, cbor2 5.2 seems to work well under python 3.10 but this could cause backwards compat issues?
|
Could someone please take a look at merging this PR? It works for me and is necessary for use in python3.10. |
|
Note that this repo/tool is not needed with NetworkTables 4, which is websockets based and can be used directly from JavaScript. |
|
Oh that's perfect, thank you. |
Oh that is great! I'll have to let my team know, atm if you do want to incude this change just drop the git link to this branch in your requirements or project pipfile or set the version back to 3.8 like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #44
Turns out the underlying issue in 44 comes from the older cbor2 version 4.9, i tested on python 3.10 with cbor2 version 5.4.2 and it seemed to work fine but im not sure if this would break older python versions.