fix: add archive repository #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue by adding a new "archive" opam repository to support repository archiving.
- Adds an opam repository entry for the "archive" repository in both Dockerfiles.
- Ensures that both the rocq-single and coq-single environments use the updated repository configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base/rocq-single/Dockerfile | Adds an opam repository entry for the "archive" repository. |
| base/coq-single/Dockerfile | Adds an opam repository entry for the "archive" repository. |
|
It looks like we should rather ask the OPAM repository maintainers to unarchive the packages we need. See rocq-community/docker-coq#81 (comment) and ocaml/opam-repository#28065. I did so for Elpi: ocaml/opam-repository#28076. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35
per ocaml/opam-repository#27977 (comment)