fix(node-resolve): error thrown with empty entry #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
changed the title
|
Please run prettier locally. There are issues with the code in the PR. |
|
formatted the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
This improves the error message displayed to the user when the entry is
""and thenode-resolveplugin is used.Before this change, the node-resolve plugin throws an error when the entry is
""that is not helpful for the user to understand the problem (Cannot read properties of undefined (reading \'match\')). Contrastingly, when not using the node-resolve plugin, rollup's error message is helpful:Could not resolve entry module "".This pull request avoids the node-resolve error so that the clearer error message is displayed to the user.