Add blockchain.outpoint.subscribe RPC #454

romanz · 2021-08-13T18:04:14Z

Following #444 (see the specification here).

Blocked until Electrum client is released with support of 1.5 protocol.

src/electrum.rs

Pantamis · 2021-08-14T17:39:00Z

Code looks very good to me (much better than mine in #446 obviously) and I successfully use it with janoside/btc-rpc-explorer#356

This "test" doesn't use the notification part however !

romanz · 2021-08-15T18:06:53Z

Thanks for testing!

Pantamis · 2021-09-09T17:40:13Z

Would it be possible to rebase this PR with current p2p branch ?

I would like to try #468 with my PR in the bitcoin explorer janoside/btc-rpc-explorer#356
Thanks :)

romanz · 2021-09-09T18:51:07Z

Thanks for the heads-up!
Rebased aec27af.

Pantamis · 2021-09-18T09:52:18Z

I suppose you will reopen this PR once Electrum 1.5 spec are merged ?

Great work on the p2p branch !

Kixunil · 2021-09-18T10:46:26Z

I think this was the same GitHub confusion as in #455

romanz · 2021-09-18T10:53:46Z

I think this was the same GitHub confusion as in #455

Yes, reopening now :)

Pantamis · 2022-11-01T19:10:30Z

Hi !

Just for information:

This PR still work as expected when cherry picked from master. This is mandatory since #783

The only thing that must be changed to make it compiling is BlockHash::default() to BlockHash::all_zeros() in OutpointStatus struct.

I re tACK this with janoside/btc-rpc-explorer/pull/356

antonilol · 2022-11-15T18:49:54Z

src/status.rs

+                    for tx in block.txdata {
+                        let txid = tx.txid();
+                        let output_len = u32::try_from(tx.output.len()).unwrap();
+                        if self.outpoint.txid == txid && self.outpoint.vout < output_len {


self.outpoint.vout < output_len

maybe i am missing something, but for what reason is this check here?

Clearly this avoids out-of-bounds access.

hmm i tried to find where self.outpoint.vout is used to index tx.output, but could not find it, self.outpoint.vout is not used after this here, which made sense after i thought of this: this code checks for output funding, it doesnt matter which output index is subscribed to, as long as it is in the transaction (self.outpoint.vout < output_len)

Oh, interesting, this is not even required for double-spend handling since a double-spent transaction would have a different txid.

Maybe there would be a value in having a sanity check with a warning? It'd be best to also check scripts then.

It's indeed a sanity check - in case the user tries to subscribe to a non-existing outpoint (by specifying a vout larger than the actual # of txid outputs).

What I'm trying to say is that it now silently ignores the transaction instead of printing a warning and a warning would be helpful because doing this is a bug and without a message it could be hard to analyze.

Kixunil · 2025-02-27T12:18:09Z

Funny, this would be useful for me now. I can use script hash and just filter the events of course but not having to do it would be nice.

romanz mentioned this pull request Aug 13, 2021

Feature: add blockchain.outpoint Electrum 1.5 methods in p2p branch #444

Open

romanz added 1.5 enhancement New feature or request labels Aug 13, 2021

Pantamis reviewed Aug 14, 2021

View reviewed changes

src/electrum.rs Outdated Show resolved Hide resolved

romanz force-pushed the p2p-outpoint-rpc branch from a1d5efa to 5d2c7cf Compare August 15, 2021 18:01

romanz force-pushed the p2p-outpoint-rpc branch from 5d2c7cf to ea5a907 Compare August 21, 2021 16:05

romanz force-pushed the p2p-outpoint-rpc branch from ea5a907 to aec27af Compare September 9, 2021 18:50

romanz force-pushed the p2p-outpoint-rpc branch 2 times, most recently from eae0905 to 7b728d4 Compare September 16, 2021 07:03

romanz mentioned this pull request Sep 17, 2021

[WIP_DO_NOT_MERGE] Add outpoint subscribe method #446

Closed

romanz force-pushed the p2p-outpoint-rpc branch 3 times, most recently from 78e62ab to 30f7401 Compare September 18, 2021 06:46

romanz deleted the branch master September 18, 2021 06:47

romanz closed this Sep 18, 2021

romanz reopened this Sep 18, 2021

romanz changed the base branch from p2p to master September 18, 2021 10:53

romanz force-pushed the p2p-outpoint-rpc branch 2 times, most recently from cd42567 to f9239e0 Compare September 23, 2021 19:24

romanz mentioned this pull request Oct 3, 2021

[Question] How to query electrs for what transaction spends a specific output? #220

Closed

romanz force-pushed the p2p-outpoint-rpc branch from f9239e0 to 919c660 Compare October 4, 2021 07:48

romanz force-pushed the p2p-outpoint-rpc branch 2 times, most recently from 7db0b8c to 049df10 Compare October 15, 2021 14:16

romanz force-pushed the p2p-outpoint-rpc branch 2 times, most recently from 08903b6 to c9cfcf5 Compare October 25, 2021 18:11

romanz force-pushed the p2p-outpoint-rpc branch 2 times, most recently from 8fe9fff to 70025e4 Compare October 30, 2021 17:15

Pantamis mentioned this pull request Nov 4, 2021

Optimize batched RPC lookups in P2P branch #464

Closed

romanz force-pushed the p2p-outpoint-rpc branch 2 times, most recently from 91b01b5 to 00faaae Compare November 19, 2021 21:12

romanz force-pushed the p2p-outpoint-rpc branch from 00faaae to af7b889 Compare December 4, 2021 21:56

romanz force-pushed the p2p-outpoint-rpc branch from af7b889 to edd1a30 Compare January 21, 2022 19:05

Pantamis mentioned this pull request Feb 15, 2022

Implementing blockchain.outpoint.subscribe method cculianu/Fulcrum#104

Open

romanz force-pushed the p2p-outpoint-rpc branch 2 times, most recently from 45a13d1 to e0d42ac Compare November 3, 2022 17:23

romanz mentioned this pull request Nov 3, 2022

Feature: query for spending transaction input txid+index #788

Open

antonilol reviewed Nov 15, 2022

View reviewed changes

romanz force-pushed the p2p-outpoint-rpc branch 2 times, most recently from c77b4d6 to e11fff1 Compare June 16, 2023 13:29

Add blockchain.outpoint.subscribe RPC

834bbd7

romanz force-pushed the p2p-outpoint-rpc branch from e11fff1 to 834bbd7 Compare June 17, 2023 17:39

9764319764319764 approved these changes Oct 5, 2024

View reviewed changes

Add blockchain.outpoint.subscribe RPC #454

Are you sure you want to change the base?

Add blockchain.outpoint.subscribe RPC #454

Conversation

romanz commented Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Pantamis commented Aug 14, 2021

Uh oh!

romanz commented Aug 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pantamis commented Sep 9, 2021

Uh oh!

romanz commented Sep 9, 2021

Uh oh!

Pantamis commented Sep 18, 2021

Uh oh!

Kixunil commented Sep 18, 2021

Uh oh!

romanz commented Sep 18, 2021

Uh oh!

Pantamis commented Nov 1, 2022

Uh oh!

antonilol Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

Kixunil Nov 16, 2022

Choose a reason for hiding this comment

Uh oh!

antonilol Nov 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kixunil Nov 21, 2022

Choose a reason for hiding this comment

Uh oh!

romanz Nov 22, 2022

Choose a reason for hiding this comment

Uh oh!

Kixunil Nov 23, 2022

Choose a reason for hiding this comment

Uh oh!

Kixunil commented Feb 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

romanz commented Aug 13, 2021 •

edited

Loading

romanz commented Aug 15, 2021 •

edited

Loading

antonilol Nov 21, 2022 •

edited

Loading