Skip to content

Conversation

sybbear
Copy link

@sybbear sybbear commented Sep 24, 2025

Hello,
this makes 3 small fixes that stops php from producing
[WARNING: Using ${var} in strings is deprecated, use {$var} instead]

Please make a new release, if it is easy to do on this 2.x branch, so we can enjoy cleaner logs

The same issue is present with version 3, however since version 4 seems fixed (search by ${)

Best regards

Hello,
this makes 3 small fixes that stops php from producing [WARNING: Using ${var} in strings is deprecated, use {$var} instead]

Please make a new release if it is easy to do.
@sybbear
Copy link
Author

sybbear commented Oct 15, 2025

Any chance to merge this?
@retlehs or someone for the team

Totally harmless fix, however significantly reduces log noise

@retlehs
Copy link
Member

retlehs commented Oct 15, 2025

Would prefer not to merge anything or release anything for Acorn 2.x

@Log1x
Copy link
Member

Log1x commented Oct 16, 2025

Is there any particular reason you can't upgrade? The upgrade path should be pretty smooth.

@sybbear
Copy link
Author

sybbear commented Oct 16, 2025

@retlehs @Log1x
Roots/acorn 3 requires L9 and version 4 requires L10
We have a pretty large system that relies on L8 and we can't upgrade it of now due to vendor constraints.

Is there something else we could do other than forking this?
I'd write tests for this PR, but there are no tests to write for these kind of changes, since the logic is exactly the same, just correct string interpolation

If you could possibly consider 🙏 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants