-
Notifications
You must be signed in to change notification settings - Fork 363
Add JOSS paper #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add JOSS paper #2246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three spots mark the same TODO of updating references. Likely it's worth doing that in this PR rather than a follow up.
|
||
From the system perspective, a robot control framework should have concept for **handling errors from hardware** (`RF5`) and **emergency stop events** (`RF6`). In those situations, hardware components can become unavailable and recovery procedures for hardware and deactivation procedures for controllers have to be implemented. | ||
|
||
<!-- % TODO: update enumeration to RF1, RF2, ... Framework requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be done during this PR or a follow up? I understand the need to put this in, but I'd like to encourage this to be touched only once. Documentation has a tendency to fall last on TODO lists.
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
Add a publication to be submitted to JOSS.
We have a problem with the large images and the current pre-commit settings. I tried to use LFS, but this did not work (anyone configured that for a public repo in a free organization?). Should we increase the max-file-size in the pre-commit config, or move the paper to a different repository, or just leave it in a not-to-be-merged branch?
Related to https://github.com/ros-controls/joss_paper
Related to #2222