Skip to content

Conversation

yahonda
Copy link
Collaborator

@yahonda yahonda commented Jul 15, 2020

This draft/wip pull request runs CI with GitHub Actions. It runs Oracle Database 18c XE.
Many specs fail due to #187

@jgebal
Copy link
Contributor

jgebal commented Jul 29, 2020

@yahonda
You might use our Dockerfiles to build docker images and put them into DockerHub.
Our images use minimal Oracle DB (stripped of a lot of stuff). They should work fine for ruby-plsql I think.

Full instructions along with working example of travis.yml, can be found here:

OraOpenSource/Logger#230

The Travis will take a bit more download Oracle DB and start it, but it is still reasonable time.

Hope his will help you kickstart on multi-DB builds.

How to organize your build matrix to make build time acceptable is a separate issue :)

Actually, the PR I've shared uses single DB.
The multi-DB approach is used in utPLSQL builds: https://github.com/utPLSQL/utPLSQL/blob/develop/.travis.yml#L52-L57

@yahonda
Copy link
Collaborator Author

yahonda commented Aug 2, 2020

@jgebal Thanks for the useful information. I still prefer not to build Oracle database docker images by myself, I think we need to address #187 first then run CI against 18c 18.3 will be a good idea.

Also yes, building matrix will be another issue to be tackled.

@jgebal
Copy link
Contributor

jgebal commented Aug 3, 2020

I'm not sure how will you install Oracle 18 XE on Travis.
Docker image seems most viable and reasonable.
The official Oracle Docker file is huge and pulling it from hub takes precious time in your build.
This is why we've created slim images that are a lot smaller and good-enough for the framework needs.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 4, 2020
@yahonda
Copy link
Collaborator Author

yahonda commented Oct 4, 2020

Let's leave it open.

@stale stale bot removed the wontfix label Oct 4, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 25, 2020
@yahonda
Copy link
Collaborator Author

yahonda commented Dec 25, 2020

Let's keep it open.

@stale stale bot removed the wontfix label Dec 25, 2020
@yahonda yahonda changed the title [WIP] Run CI with GitHub Actions Run CI with GitHub Actions to run Oracle database 18c Jul 29, 2021
@yahonda
Copy link
Collaborator Author

yahonda commented Jul 29, 2021

Since #196 has been merged to support Oracle 18c, I think this pull request can be merged.

@yahonda yahonda marked this pull request as ready for review July 29, 2021 10:04
@yahonda yahonda closed this Jul 29, 2021
@yahonda yahonda force-pushed the run_ci_at_actions branch from f92ed49 to 4c33681 Compare July 29, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants