Properly handle Unicode and escapes #713
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: This is work in progress, the code is rough around the edges and not SIMD configurations are implemented.
Short description
This is a big one, it has been over a year in the making now.
Strings used in queries are now compiled into
StringPatternstructures that contain precomputed tables for unicode and escape-aware matching of keys.This finally makes us spec-compliant when it comes to string comparison. However, it is most likely significantly slower, and the matching algorithm is quite complicated.
Before this gets merged the following things need to be addressed:
Issue
Resolves: #117
Checklist
All of these should be ticked off before you submit the PR.
just verifylocally and it succeeded.