Skip to content

Conversation

@rlamacraft
Copy link
Contributor

No description provided.

@rlamacraft
Copy link
Contributor Author

@mKowalski256 Still working on much of it, but figured you might want to get ahead of reviewing as I go + looking at adding to the section on authentication

@rlamacraft rlamacraft force-pushed the new-tinymce-plugin-docs branch 5 times, most recently from bd7a3f8 to 93f7096 Compare February 20, 2025 17:30
Comment on lines +73 to +75
Lets define a script in `src/main/webapp/ui/tinyMCE/plugins/newPlugin/index.js`,
inside of which we will call `tinymce.PluginManager.add("newPlugin", NewPlugin);`,
where `NewPlugin` is a class. This class doesn't need to have any particular
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This describes the way of writing new React-based plugin, which I think is a way preferred by us, but would it be worth mentioning that it's possible to write pure javascript-based plugin, and that various implementations can be found in src/main/webapp/scripts/externalTinymcePlugins?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because we'll only have to migrate them ourselves when we migrate the document editor to react. The logic specific to each plugin can still be implemented using any tech stack because the dialog content can be an iframe (as I mention), but the dialog itself should be a react component so that it is consistent with the rest of the our product in terms of design, access to the help system, etc.

@rlamacraft rlamacraft force-pushed the new-tinymce-plugin-docs branch from 93f7096 to 12799ea Compare March 18, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants