-
Notifications
You must be signed in to change notification settings - Fork 13
New tinymce plugin docs #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New tinymce plugin docs #269
Conversation
|
@mKowalski256 Still working on much of it, but figured you might want to get ahead of reviewing as I go + looking at adding to the section on authentication |
bd7a3f8 to
93f7096
Compare
| Lets define a script in `src/main/webapp/ui/tinyMCE/plugins/newPlugin/index.js`, | ||
| inside of which we will call `tinymce.PluginManager.add("newPlugin", NewPlugin);`, | ||
| where `NewPlugin` is a class. This class doesn't need to have any particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This describes the way of writing new React-based plugin, which I think is a way preferred by us, but would it be worth mentioning that it's possible to write pure javascript-based plugin, and that various implementations can be found in src/main/webapp/scripts/externalTinymcePlugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because we'll only have to migrate them ourselves when we migrate the document editor to react. The logic specific to each plugin can still be implemented using any tech stack because the dialog content can be an iframe (as I mention), but the dialog itself should be a react component so that it is consistent with the rest of the our product in terms of design, access to the help system, etc.
93f7096 to
12799ea
Compare
No description provided.