Skip to content

Conversation

@tchoi-rs
Copy link
Collaborator

Description

Removes the alternative card-style share dialog layout so the interface is the same, no matter how many items are being shared at one time.

@github-actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Timothy Choi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@tchoi-rs tchoi-rs requested a review from mKowalski256 October 30, 2025 17:43
@tchoi-rs tchoi-rs changed the title PRT-1013 remove card-style share dialog layout WIP: PRT-1013 remove card-style share dialog layout Oct 30, 2025
@tchoi-rs tchoi-rs changed the title WIP: PRT-1013 remove card-style share dialog layout PRT-1013 remove card-style share dialog layout Oct 31, 2025
Copy link
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on the JIRA ticket - the change does work as described, but it seems that we're loosing some functionality when removing the card-style layout of the dialog. Particularly for selection of multiple records, where some are already shared, the behaviour of unified table-style layout is very confusing.

Let's not merge for now, until specs are re-discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants