feat: conversion #29
Open
feat: conversion #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] main from rspack-contrib:main
…skip larger files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A build system supporting conversion would alleviate time consuming chores, and could be used to guarantee format consistency across all bundled images.
Description
This changes initially took the route to augment the
minimizerplugin. The conversion behaviors however do not overlap entirely with the processes of compression, so a separate plugin was implemented instead. Reusing logic and types where applicable.A separate plugin makes it easier to maintain and extend the minimizer's behavior.
Why not a separate package?
This package name in fact remains inline with conversion features, I think.
Is this ready?
I don't believe so. It's working, but questions remain about the dual plugin inside a package. Plus I'm not familiar with rspack to test that usage with confidence.
Also the API needs to be finalized by the core maintainers, attempted to stay closely aligned with the minimizer plugin for now.