Less active support concern #2574
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors several DSL modules by switching from instance inclusion to class extension, removes reliance on ActiveSupport::Concern, and cleans up deprecated or redundant code. Key changes include:
- Removal of legacy tests for Grape::DSL::Validations in the integration specs.
- Updating DSL modules and helper methods across multiple files to use concise patterns and extend modules.
- Eliminating deprecated code files and streamlining settings and middleware definitions.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/integration/dry_validation/dry_validation_spec.rb | Removed the Grape::DSL::Validations tests to deprecate inactive support |
| spec/grape/validations/validators/coerce_validator_spec.rb | Updated to refer to Grape::Validations::Types::InvalidValue for consistency |
| spec/grape/dsl/* and lib/grape/dsl/* | Converted many modules from include to extend and removed ActiveSupport::Concern usage, among other DSL cleanup changes |
| lib/grape/api/* | Simplified API instance logger handling and removed deprecated helper definitions |
Comments suppressed due to low confidence (1)
spec/integration/dry_validation/dry_validation_spec.rb:3
- The removal of tests for Grape::DSL::Validations may reduce coverage; please ensure that the new behavior is adequately tested elsewhere.
describe 'Dry::Schema', if: defined?(Dry::Schema) do
ericproulx
force-pushed
the
less_active_support_concern
branch
from
002f15b to
369445c
Compare
ericproulx
force-pushed
the
less_active_support_concern
branch
6 times, most recently
from
2ff6075 to
4a89c18
Compare
| it 'evaluates block' do | ||
| expect { subject.params { raise 'foo' } }.to raise_error RuntimeError, 'foo' | ||
| def self.namespace_stackable_hash | ||
| @namespace_stackable_hash ||= Hash.new do |hash, key| |
There was a problem hiding this comment.
This causes a side effect, doesn't it? Clear it? A few other instances of the same, let's make sure tests don't leak.
There was a problem hiding this comment.
I've done the same pattern elsewhere. Since some module are dependent, I need to recreate the functions in the anonymous class.
This won't leak
There was a problem hiding this comment.
Since some modules are dependent, i'll check if I can combine them.
ericproulx
force-pushed
the
less_active_support_concern
branch
from
4a89c18 to
50875c2
Compare
Here's an example of a CHANGELOG.md entry: * [#2574](https://github.com/ruby-grape/grape/pull/2574): Less active support concern - [@ericproulx](https://github.com/ericproulx).Generated by 🚫 Danger |
ericproulx
force-pushed
the
less_active_support_concern
branch
3 times, most recently
from
b22431a to
c5771ff
Compare
Remove invalid value short name (not used)
ericproulx
force-pushed
the
less_active_support_concern
branch
from
c5771ff to
0df0860
Compare
Refactor DSL modules by removing unnecessary ActiveSupport::Concern
This PR refactors the Grape DSL modules to remove unnecessary
ActiveSupport::Concernusage and simplify the codebase architecture.Changes
DSL Module Refactoring
ActiveSupport::Concernfrom all DSL modules where it was unnecessaryincludedandextendedcallbacks that weren't providing valueAffected Modules
Grape::DSL::Callbacks- Simplified callback registrationGrape::DSL::Helpers- Streamlined helper module inclusionGrape::DSL::Routing- Cleaner route definition and mountingGrape::DSL::RequestResponse- Simplified request/response handlingGrape::DSL::Settings- Cleaner configuration managementGrape::DSL::Validations- Streamlined validation setupGrape::DSL::Middleware- Simplified middleware configurationGrape::DSL::Parameters- Cleaner parameter handlingGrape::DSL::Logger- Simplified logging setupGrape::DSL::InsideRoute- Streamlined route executionGrape::DSL::Desc- Simplified description handlingGrape::DSL::Configuration- Cleaner configuration managementCode Cleanup
invalid_valueshort name that wasn't being usedTesting
Benefits
Performance
Maintainability
Compatibility
Impact
This refactoring is a non-breaking change that improves the internal architecture of Grape's DSL system. All existing Grape applications will continue to work without modification, but will benefit from:
Testing