feat: Re-use core models in SDK #104
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 75.95% 75.94% -0.01%
==========================================
Files 32 32
Lines 2429 2428 -1
==========================================
- Hits 1845 1844 -1
Misses 584 584 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
csurfer
commented
Apr 15, 2025
Comment on lines
+76
to
+98
| for f in class_files: | ||
| mod_path = str(f.with_suffix("")).removeprefix(str(root.parent)) | ||
| mod = get_module(mod_path) | ||
| if mod.startswith("galileo_core.testing"): | ||
| continue | ||
| module = importlib.import_module(mod) | ||
|
|
||
| print(">>", mod) | ||
| for item in dir(module): | ||
| ic = getattr(module, item) | ||
| if not item.startswith("__") and inspect.isclass(ic) and ic.__module__.startswith("galileo"): | ||
| print(" >>", item, camel_to_snake(item)) | ||
| with open(f"{MODEL_LOCATION_PREFIX}/{camel_to_snake(item)}.py", "w") as f: | ||
| f.write(basemodel_dict_template.render({"unified_file_name": unified_file_name, "item": item})) | ||
| mod_import_list.append((mod, item)) | ||
| elif ( | ||
| not item.startswith("__") | ||
| and "__class__" in dir(ic) | ||
| and ic.__class__ == typing._AnnotatedAlias | ||
| and item not in {"UUID4"} | ||
| ): | ||
| mod_other_list.append((mod, item)) | ||
| print() |
There was a problem hiding this comment.
Core module iteration + class creation + linkage
csurfer
commented
Apr 15, 2025
Comment on lines
+2071
to
+2098
| if issubclass(GalileoCoreMessageClass, BaseModel): | ||
|
|
||
| class Message(GalileoCoreMessageClass): | ||
| def to_dict(self) -> dict[str, Any]: | ||
| return self.model_dump(exclude_none=True) | ||
|
|
||
| @classmethod | ||
| def from_dict(cls, src_dict: dict[str, Any]) -> "Message": | ||
| return cls.model_validate(src_dict) | ||
|
|
||
| Message.model_rebuild() | ||
| else: | ||
| Message = GalileoCoreMessageClass | ||
|
|
||
|
|
||
| if issubclass(GalileoCoreMessageRoleClass, BaseModel): | ||
|
|
||
| class MessageRole(GalileoCoreMessageRoleClass): | ||
| def to_dict(self) -> dict[str, Any]: | ||
| return self.model_dump(exclude_none=True) | ||
|
|
||
| @classmethod | ||
| def from_dict(cls, src_dict: dict[str, Any]) -> "MessageRole": | ||
| return cls.model_validate(src_dict) | ||
|
|
||
| MessageRole.model_rebuild() | ||
| else: | ||
| MessageRole = GalileoCoreMessageRoleClass |
There was a problem hiding this comment.
Generated class wrappers with model rebuilds.
csurfer
commented
Apr 15, 2025
| return str(self.value) | ||
| # flake: noqa: F401 | ||
| # ruff: noqa: F401 | ||
| from ..models.all_galileo_core_models import MessageRole |
There was a problem hiding this comment.
Link individual model file to import the right definition from all model file to ensure generated clients can still use these models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposed solution and thought process documentation : Link