-
Notifications
You must be signed in to change notification settings - Fork 6
perf: Speed up method GalileoDecorator._is_method
by 33%
#117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
misrasaurabh1
wants to merge
5
commits into
rungalileo:main
Choose a base branch
from
misrasaurabh1:codeflash/optimize-GalileoDecorator._is_method-ma3jjm09
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
perf: Speed up method GalileoDecorator._is_method
by 33%
#117
misrasaurabh1
wants to merge
5
commits into
rungalileo:main
from
misrasaurabh1:codeflash/optimize-GalileoDecorator._is_method-ma3jjm09
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is your optimized Python program. All comments are preserved unless the code they describe was changed. The major bottleneck in your code is calling `inspect.signature(func)` **twice** in `_is_method`, which can be expensive. We will compute it once and reuse it. Additionally, the docstrings and structure are retained. **Optimization summary:** - Only call `inspect.signature(func)` once per call to `_is_method` rather than twice, reducing function call overhead and making your code run faster. - No changes to function signatures, variable names, logic, or return values. - All original comments preserved. - No extraneous code added.
GalileoDecorator._is_method
by 33%GalileoDecorator._is_method
by 33%
lan17
approved these changes
May 4, 2025
@@ -361,7 +361,9 @@ def _is_method(func: Callable) -> bool: | |||
Returns: | |||
bool: True if 'cls' or 'self' is in the callable's parameters, False otherwise | |||
""" | |||
return "self" in inspect.signature(func).parameters or "cls" in inspect.signature(func).parameters | |||
# Only call inspect.signature(func) ONCE for improved performance | |||
params = inspect.signature(func).parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
andriisoldatenko
approved these changes
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please remove comment, it's redundunt!
Co-authored-by: Andrii Soldatenko <andrii.soldatenko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π 33% (0.33x) speedup for
GalileoDecorator._is_method
insrc/galileo/decorator.py
β±οΈ Runtime :
578 microseconds
β433 microseconds
(best of156
runs)π Explanation and details
Here is your optimized Python program.
All comments are preserved unless the code they describe was changed.
The major bottleneck in your code is calling
inspect.signature(func)
twice in_is_method
, which can be expensive. We will compute it once and reuse it.Additionally, the docstrings and structure are retained.
Optimization summary:
inspect.signature(func)
once per call to_is_method
rather than twice, reducing function call overhead and making your code run faster.β Correctness verification report:
π Generated Regression Tests Details
To edit these changes
git checkout codeflash/optimize-GalileoDecorator._is_method-ma3jjm09
and push.