fix: langchain on_chain_start with_kwargs name and serialised is none #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 78.64% 78.64%
=======================================
Files 36 36
Lines 2664 2664
=======================================
Hits 2095 2095
Misses 569 569 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pratduv
reviewed
May 23, 2025
| @@ -262,7 +262,7 @@ def on_chain_start( | |||
| ) -> Any: | |||
| """Langchain callback when a chain starts.""" | |||
| node_type = "chain" | |||
| node_name = self._get_node_name(node_type, serialized) | |||
| node_name = self._get_node_name(node_type, serialized) if serialized else kwargs.get("name", "Chain") | |||
There was a problem hiding this comment.
Approving as an add back from here - https://github.com/rungalileo/galileo-python/pull/118/files#diff-781a86c6b7ec1f42cf974392bcdfb90c9e76a6c3dd6ca9f55795faaa9ca85af4R265
pratduv
approved these changes
May 23, 2025
|
Thanks for the fix, @andriisoldatenko |
ajaynayak
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes https://app.shortcut.com/galileo/story/31460/langgraph-tracing-metrics-don-t-work-properly
after https://github.com/rungalileo/galileo-python/pull/118/files
After this PR:
Before this PR: