-
Notifications
You must be signed in to change notification settings - Fork 139
feat: Syslog-adapted formating and auto-detection #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
From our contrib docs
Going to mark this as a draft for now. |
Its not really a draft though, it works as is. I am already using it. |
We do not have agreement that this solution is in the direction we want to go and so this is only a proposal for demonstrating a direction, regardless of how useful it is to you in the moment. Having this be a draft (or closed) clarifies how this is being treated and pushes discussion on solutions to a single place, the issue. |
oh, ok so a draft from the project side, i guess that makes sense. i usually see the draft mode used from the contributor side to indicate work-in-progress status. |
Yes, but considering we don't yet know what directions this may change, we can't say this is ready for review. |
i kinda want to slightly alter the log format, right now syslog contains
i would like i am unsure what the easiest way to get the top level binary name is though. then it would be a simple .strip_prefix(name). |
should be merged after this: #363 |
cab5e77
to
dbf4a04
Compare
closes #357
closes #349
this is a surprisingly low diff size.