Skip to content

Fix generic param for generate_default_from_enum_variant #20362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

A4-Tacks
Copy link
Contributor

@A4-Tacks A4-Tacks commented Aug 2, 2025

Input:

//- minicore: default
enum Variant<T> {
    Defined(T),
    Undefi$0ned,
}

Old:

enum Variant<T> {
    Defined(T),
    Undefined,
}

impl Default for Variant {
    fn default() -> Self {
        Self::Undefined
    }
}

This PR fixed:

enum Variant<T> {
    Defined(T),
    Undefined,
}

impl<T> Default for Variant<T> {
    fn default() -> Self {
        Self::Undefined
    }
}

Input:
```rust
//- minicore: default
enum Variant<T> {
    Defined(T),
    Undefi$0ned,
}
```
Old:
```rust
enum Variant<T> {
    Defined(T),
    Undefined,
}

impl Default for Variant {
    fn default() -> Self {
        Self::Undefined
    }
}
```
This PR fixed:
```rust
enum Variant<T> {
    Defined(T),
    Undefined,
}

impl<T> Default for Variant<T> {
    fn default() -> Self {
        Self::Undefined
    }
}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants