In handlers/extract_module.rs, generate ast::Module instead of String #20373
+126
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Hmikihiro
changed the title
Hmikihiro
force-pushed
the
generate_module_as_ast_instead_of_str
branch
from
e8e23b1 to
794dd86
Compare
DropDemBits
reviewed
Aug 4, 2025
Hmikihiro
force-pushed
the
generate_module_as_ast_instead_of_str
branch
2 times, most recently
from
88c51bc to
e6ee6bd
Compare
ShoyuVanilla
reviewed
Aug 5, 2025
ShoyuVanilla
reviewed
Aug 5, 2025
Hmikihiro
force-pushed
the
generate_module_as_ast_instead_of_str
branch
from
e6ee6bd to
fcd4010
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I migrate to use 'SyntaxEditor', It needs AstNode instead of String.
bug fix:
2025-08-04.18.04.35.mov
to:
2025-08-04.18.11.03.mov